Feature/bugfix return codes#274
Closed
markussiebert wants to merge 4 commits intoenvato:masterfrom
markussiebert:feature/bugfix_return_codes
Closed
Feature/bugfix return codes#274markussiebert wants to merge 4 commits intoenvato:masterfrom markussiebert:feature/bugfix_return_codes
markussiebert wants to merge 4 commits intoenvato:masterfrom
markussiebert:feature/bugfix_return_codes
Conversation
patrobinson
previously approved these changes
Feb 2, 2019
patrobinson
reviewed
Feb 2, 2019
Contributor
patrobinson
left a comment
patrobinson
left a comment
There was a problem hiding this comment.
It'd be good to have some tests for these, so we don't accidentally break this functionality in the future. Do you want to take a stab at creating the cucumber tests in features/ or would you like my help?
Author
|
Let me see if i'm able to write some cucumber tests... |
Contributor
|
Does this PR solve the issue? #276 |
Contributor
|
I think this is fixed in #280 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this pull request i want to change the exit codes of stack_master for apply and delete, because they are 0 at the moment(everything ok) even if apply can't find parameters and delete can't find the stack to delete.
Now the exit code of this commands will return 1 if they fail.
We need this for using stack_master in cicd pipelines. At the moment the pipeline state is ok/green, even if some commands failed.
This belongs to issue #235